ImmichFrame.Core/Logic/Pool/PeopleAssetsPool.cs (1)

12-23: ⚠️ Potential issue | 🟠 Major

Guard against empty People in AND mode to avoid unintended search calls.

At Line 21, RequireAllPeople=true with an empty people list creates a single empty group and still executes SearchAssetsAsync. Add an early Count == 0 return to keep filtering behavior safe and predictable.

💡 Proposed fix

         var people = accountSettings.People;
-        if (people == null)
+        if (people == null || people.Count == 0)
         {
             return personAssets;
         }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ImmichFrame.Core/Logic/Pool/PeopleAssetsPool.cs` around lines 12 - 23, The
code builds personIdGroups from accountSettings.People and in AND mode
(accountSettings.RequireAllPeople) it can create a single empty group causing
SearchAssetsAsync to run; add an early guard after the null check that if
accountSettings.RequireAllPeople is true and accountSettings.People.Count == 0
then return personAssets immediately to avoid performing searches for an empty
people list; update the logic around personIdGroups, RequireAllPeople, and the
call sites that use personIdGroups/SearchAssetsAsync so the empty-case is
short-circuited.

ImmichFrame.Core/Logic/Pool/PeopleAssetsPool.cs (1)

48-52: ⚠️ Potential issue | 🟠 Major

Pagination condition uses the wrong signal and can drop pages.

Line 52 compares total to batchSize; this usually reflects global match count, not items returned in the current page. For totals > 1000, pagination can stop early after page 1.

Proposed fix

-            int total;
+            int itemsInPage;
             do
             {
                 var metadataBody = new MetadataSearchDto
                 {
                     Page = page,
                     Size = batchSize,
                     PersonIds = personIds,
                     WithExif = true,
                     WithPeople = true
                 };

                 if (!accountSettings.ShowVideos)
                 {
                     metadataBody.Type = AssetTypeEnum.IMAGE;
                 }

                 var personInfo = await immichApi.SearchAssetsAsync(metadataBody, ct);

-                total = personInfo.Assets.Total;
+                itemsInPage = personInfo.Assets.Items.Count;

                 personAssets.AddRange(personInfo.Assets.Items);
                 page++;
-            } while (total == batchSize);
+            } while (itemsInPage == batchSize);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@ImmichFrame.Core/Logic/Pool/PeopleAssetsPool.cs` around lines 48 - 52, The
pagination loop in PeopleAssetsPool (in PeopleAssetsPool.cs) uses the wrong
condition—comparing total to batchSize—so pagination can stop early; change the
loop to continue while the current page returned a full batch (e.g., while
(personInfo.Assets.Items.Count == batchSize) or equivalent) and rely on the
returned item count (personInfo.Assets.Items) instead of total; ensure
personAssets.AddRange(personInfo.Assets.Items) and page++ remain unchanged and
that total is used only for metadata, not the loop condition.